Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Generate SLSA provenance for SBOM (#14438) (cherry-pick #14507) #14559

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

enteraga6
Copy link
Contributor

closes #14438
cherry pick from #14507

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
    Use SLSA attestations to attest to SBOMs #14438
    chore: Generate SLSA provenance for SBOM (#14438) #14507

  • The title of the PR states what changed and the related issues number (used for the release note).

  • The title of the PR conforms to the Toolchain Guide

  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.

  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.

  • Does this PR require documentation updates?

  • I've updated documentation as required by this PR.

  • Optional. My organization is added to USERS.md.

  • I have signed off all my commits as required by DCO

  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.

Tested release workflow for cherry pick branch here using this workflow

Downloaded SBOM artifact and verified provenance with SLSA Verifier on local CLI with successful result:

Verified signature against tlog entry index 27800863 at URL: https://rekor.sigstore.dev/api/v1/log/entries/24296fb24b8ad77afe2aebf1b216af2aa2bfd6cc58a45214c12b663af287eb3458f4ba1b1d890337
Verified build using builder "https://github.com/slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@refs/tags/v1.7.0" at commit 0918387cbede929124dbe6e2c32e13632bfc065b
Verifying artifact sbom (1).tar.gz: PASSED

PASSED: Verified SLSA provenance
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

…4507)

* Add provenance generation for sbom

Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>

* upload SBOM

Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>

* Remove cosign setup

Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>

* include hashes in generate-sbom output

Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>

* Replace Cosign Verification command with SLSA command in docs

Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>

* Remove id-token write permission - no longer needed

Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>

---------

Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
Signed-off-by: Noah Elzner <elzner@google.com>
Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
@enteraga6 enteraga6 changed the title Cherry[2.8]: Generate SLSA provenance for SBOM (#14438) chore: Generate SLSA provenance for SBOM (#14438) (cherry-pick #14507) Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5dd9bdc) 49.82% compared to head (256599d) 49.82%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-2.8   #14559   +/-   ##
============================================
  Coverage        49.82%   49.82%           
============================================
  Files              261      261           
  Lines            44751    44751           
============================================
  Hits             22295    22295           
  Misses           20264    20264           
  Partials          2192     2192           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev merged commit 9612f73 into argoproj:release-2.8 Jul 18, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants